[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_devic
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet |
Date: |
Wed, 23 Oct 2013 11:13:33 +0100 |
On 17 October 2013 14:54, <address@hidden> wrote:
> From: Markus Armbruster <address@hidden>
>
> device_add plugs devices into suitable bus. For "real" buses, that
> actually connects the device. For sysbus, the connections need to be
> made separately, and device_add can't do that. The device would be
> left unconncected, and could not possibly work.
"unconnected"
>
> Many, but not all sysbus devices alreasy set
"already"
> cannot_instantiate_with_device_add_yet in their class init function.
>
> Set it in their abstract base's class init function
> sysbus_device_class_init(), and remove the now redundant assignments
> from device class init functions.
So I think this change is probably OK (but see my comments on
patch 1 about what our definition of the flag is supposed to be).
But I'd like to see a list of the devices which this patch makes no-user
which previously weren't. Then I could eyeball the list and check
whether there's anything in it which shouldn't be.
thanks
-- PMM
- [Qemu-devel] [PATCH 00/10] Clean up and fix no_user, armbru, 2013/10/17
- [Qemu-devel] [PATCH 04/10] apic: Document why cannot_instantiate_with_device_add_yet, armbru, 2013/10/17
- [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet, armbru, 2013/10/17
- Re: [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet,
Peter Maydell <=
- [Qemu-devel] [PATCH 01/10] qdev: Replace no_user by cannot_instantiate_with_device_add_yet, armbru, 2013/10/17
- [Qemu-devel] [PATCH 03/10] cpu: Document why cannot_instantiate_with_device_add_yet, armbru, 2013/10/17
- [Qemu-devel] [PATCH 08/10] vt82c686: Clean up use of cannot_instantiate_with_device_add_yet, armbru, 2013/10/17
- [Qemu-devel] [PATCH 05/10] pci-host: Consistently set cannot_instantiate_with_device_add_yet, armbru, 2013/10/17