Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c

[Wenchao Xia]

于 2013/10/18 17:36, Paolo Bonzini 写道:
> Il 18/10/2013 03:11, Wenchao Xia ha scritto:
> > block_int.h already included it.
> >
> > Signed-off-by: Wenchao Xia <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > ---
> >   block.c |    1 -
> >   1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/block.c b/block.c
> > index 2c15e5d..e92a556 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -24,7 +24,6 @@
> >   #include "config-host.h"
> >   #include "qemu-common.h"
> >   #include "trace.h"
> > -#include "monitor/monitor.h"
> >   #include "block/block_int.h"
> >   #include "block/blockjob.h"
> >   #include "qemu/module.h"
> Does this cause problems?  block.c uses monitor_protocol_event, so it's
> good to include the file directly instead of relying on other header files.
>
> Paolo
OK, will drop this patch.