[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/5] Fix configure script for LTTng 2.x
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/5] Fix configure script for LTTng 2.x |
Date: |
Fri, 18 Oct 2013 16:05:28 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 18, 2013 at 02:39:49AM -0400, Mohamad Gebai wrote:
> Signed-off-by: Mohamad Gebai <address@hidden>
> ---
> configure | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 23dbaaf..627054c 100755
> --- a/configure
> +++ b/configure
> @@ -3287,15 +3287,14 @@ fi
> # For 'ust' backend, test if ust headers are present
> if test "$trace_backend" = "ust"; then
> cat > $TMPC << EOF
> -#include <ust/tracepoint.h>
> -#include <ust/marker.h>
> +#include <lttng/tracepoint.h>
> int main(void) { return 0; }
> EOF
> if compile_prog "" "" ; then
> - LIBS="-lust -lurcu-bp $LIBS"
> - libs_qga="-lust -lurcu-bp $libs_qga"
> + LIBS="-llttng-ust -lurcu-bp -ldl $LIBS"
> + libs_qga="-llttng-ust -lurcu-bp -ldl $libs_qga"
Please switch to pkg-config instead of hardcoding particular flags. I
checked that Fedora and Debian ship the pkg-config file.
- [Qemu-devel] [PATCH v4 0/5] Fix UST backend for LTTng 2.x, Mohamad Gebai, 2013/10/18
- [Qemu-devel] [PATCH v4 2/5] Modified the tracetool framework for LTTng 2.x., Mohamad Gebai, 2013/10/18
- [Qemu-devel] [PATCH v4 3/5] Adapt Makefiles to the new LTTng ust interface., Mohamad Gebai, 2013/10/18
- [Qemu-devel] [PATCH v4 4/5] Update documentation for LTTng ust tracing, Mohamad Gebai, 2013/10/18
- [Qemu-devel] [PATCH v4 5/5] Add ust generated files to .gitignore, Mohamad Gebai, 2013/10/18
- Re: [Qemu-devel] [PATCH v4 0/5] Fix UST backend for LTTng 2.x, Alex Bennée, 2013/10/18