Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

[Peter Maydell]

On 18 October 2013 12:45,  <address@hidden> wrote:
> From: Alex Bennée <address@hidden>
>
> Commit 9b8c69243 (since reverted) broke the ability to boot the kernel
> as the value returned by unassigned_mem_read returned non-zero and left
> the kernel looping forever waiting for it to change (see
> integrator_led_set in the kernel code).
>
> Relying on a varying implementation detail is incorrect anyway so this
> introduces a basic stub of a memory region for the debug/LED section
> on the integrator board.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  hw/arm/Makefile.objs              |   3 +-
>  hw/arm/integrator_debug.c         | 103 
> ++++++++++++++++++++++++++++++++++++++
>  hw/arm/integratorcp.c             |   2 +
>  include/hw/arm/integrator_debug.h |  18 +++++++
>  4 files changed, 125 insertions(+), 1 deletion(-)
>  create mode 100644 hw/arm/integrator_debug.c
>  create mode 100644 include/hw/arm/integrator_debug.h
>
> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs
> index 3671b42..ffdf7ee 100644
> --- a/hw/arm/Makefile.objs
> +++ b/hw/arm/Makefile.objs
> @@ -1,5 +1,6 @@
>  obj-y += boot.o collie.o exynos4_boards.o gumstix.o highbank.o
> -obj-y += integratorcp.o kzm.o mainstone.o musicpal.o nseries.o
> +obj-y += integratorcp.o integrator_debug.o
> +obj-y += kzm.o mainstone.o musicpal.o nseries.o
>  obj-y += omap_sx1.o palm.o realview.o spitz.o stellaris.o
>  obj-y += tosa.o versatilepb.o vexpress.o xilinx_zynq.o z2.o
>
> diff --git a/hw/arm/integrator_debug.c b/hw/arm/integrator_debug.c
> new file mode 100644
> index 0000000..c9dd7f0
> --- /dev/null
> +++ b/hw/arm/integrator_debug.c

Oh, and this belongs in hw/misc/, since it's a standalone
device model.

thanks
-- PMM