qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define
Date: Fri, 18 Oct 2013 06:38:02 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0

On 10/18/2013 03:36 AM, Paolo Bonzini wrote:
> Il 18/10/2013 03:11, Wenchao Xia ha scritto:
>> Signed-off-by: Wenchao Xia <address@hidden>
>> ---
>>  include/monitor/monitor.h |   38 +-------------------------
>>  include/qapi/qmp/qevent.h |   66 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>  include/qapi/qmp/types.h  |    1 +
>>  3 files changed, 68 insertions(+), 37 deletions(-)
>>  create mode 100644 include/qapi/qmp/qevent.h

>>
> 
> Please move it qemu-schema.json instead.

qapi-schema.json, but yes, I agree that declaring it as a qapi enum and
letting the code generator create the constants, rather than moving the
hand-maintained constants into a new header, is smarter.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]