[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info |
Date: |
Fri, 18 Oct 2013 12:02:17 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 17, 2013 at 12:34:27PM +0300, Michael S. Tsirkin wrote:
> On Thu, Oct 17, 2013 at 04:31:22PM +0800, Amos Kong wrote:
> > On Thu, Oct 17, 2013 at 11:15:21AM +0300, Michael S. Tsirkin wrote:
> > > On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote:
> > > > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote:
> > > > > I tried to change macaddr in guest, addr in guest is updated, and
> > > > > guest
> > > > > network is fine. But the nic information in monitor isn't update. This
> > > > > problem both exists in e1000 and rtl8139.
> > > > >
> > > > > 1) change macaddr in guest by ifconfig
> > > > > guest)# ifconfig eth0 hw ether 12:12:12:34:35:36
> > > > > guest)# ifconfig eth0
> > > > >
> > > > > 2) check network information in monitor
> > > > > (qemu) info network
> > > > >
> > > > > Amos Kong (2):
> > > > > net/e1000: update network information when macaddr is changed in
> > > > > guest
> > > > > net/rtl8139: update network information when macaddr is changed in
> > > > > guest
> > > > >
> > > > > hw/net/e1000.c | 8 ++++++++
> > > > > hw/net/rtl8139.c | 6 +++++-
> > > > > 2 files changed, 13 insertions(+), 1 deletion(-)
> > > >
> > > > Thanks, applied to my net tree:
> > > > https://github.com/stefanha/qemu/commits/net
> > > >
> > > > Stefan
> > >
> > > Please revert, this is buggy:
> > >
> > > info is changed on guest mac write but is
> > > not reverted on reset.
> > >
> > > Let's fix it properly, no need to introduce
> > > new regressions when fixing old bugs :)
> >
> > After 'system_reset' or 'reboot', nic info can't be changed until
> > device init.
> >
> > Updating nic info during reset is another issue, I will send patch to
> > fix it.
>
> OK so let's apply the reset change first, then these patches
> on top. This way we don't break bisect.
> Stefan can you rearrange pls?
Yes, I will reorder the patches. Thanks for spotting this problem.
Stefan