Re: [Qemu-devel] [PATCH v1 4/4] target-arm: Add CP15 VBAR support

[Peter Maydell]

On 10 July 2013 05:23,  <address@hidden> wrote:
> From: Nathan Rossi <address@hidden>
>
> Added Vector Base Address remapping on ARM v7.

Apologies for this dropping off my radar for so long.
I've had a bit of a think and I think that you're right
that we can put in this register as part of our "random
things we provide even though we aren't strictly implementing
all of TZ", like the existing SCR register support.

> +static int vbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
> +                      uint64_t value)
> +{
> +    value &= (1 << 31);

This seems spurious -- we end up ignoring all but
the high bit of the written value.

> +    env->cp15.c12_vbar = value & ~0x1Ful;
> +    return 0;
> +}
> +

Otherwise looks OK. We should probably put in an ARM_FEATURE_TZ
at some point, but for now putting it in the v7 regs with SCR is
OK I think.

-- PMM