[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: update nic info during device reset
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] net: update nic info during device reset |
Date: |
Thu, 17 Oct 2013 12:34:40 +0300 |
On Thu, Oct 17, 2013 at 04:38:34PM +0800, Amos Kong wrote:
> macaddr is reset during device reset, but nic info
> isn't updated, this problem exists in e1000 & rtl8139
>
> Signed-off-by: Amos Kong <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/net/e1000.c | 1 +
> hw/net/rtl8139.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 7769be0..70a59fd 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -401,6 +401,7 @@ static void e1000_reset(void *opaque)
> d->mac_reg[RA] |= macaddr[i] << (8 * i);
> d->mac_reg[RA + 1] |= (i < 2) ? macaddr[i + 4] << (8 * i) : 0;
> }
> + qemu_format_nic_info_str(qemu_get_queue(d->nic), macaddr);
> }
>
> static void
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index 248d9e9..3225f3d 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -1214,6 +1214,7 @@ static void rtl8139_reset(DeviceState *d)
>
> /* restore MAC address */
> memcpy(s->phys, s->conf.macaddr.a, 6);
> + qemu_format_nic_info_str(qemu_get_queue(s->nic), s->phys);
>
> /* reset interrupt mask */
> s->IntrStatus = 0;
> --
> 1.8.3.1