qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()


From: mike
Subject: Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()
Date: Thu, 17 Oct 2013 16:35:52 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 10/17/2013 04:11 PM, Kevin Wolf wrote:
Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben:
Change to v1:
        remove '[not inserted]' line instead of adding '\n'
Please put such notes for reviewers below the --- line, so that git am
automatically removes them and they don't end up in the git commit
message.
OK, thanks for your kindly remind,

Thanks
Mike
Output of 'info block'

scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
  [not inserted]
scsi0-cd2: [not inserted]
     Removable device: not locked, tray closed

floppy0: [not inserted]
     Removable device: not locked, tray closed

sd0: [not inserted]
     Removable device: not locked, tray closed

There will be no additional lines between scsi0-hd0 and
scsi0-cd2.

At the same time, scsi0-hd0 already inserted, but still has
'[not inserted]' flag. This line should be removed.

This patch is to solve this.

Signed-off-by: Mike Qiu <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>







reply via email to

[Prev in Thread] Current Thread [Next in Thread]