[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet |
Date: |
Thu, 17 Oct 2013 08:45:10 +0300 |
On Thu, Oct 17, 2013 at 11:16:01AM +0800, Liu Ping Fan wrote:
> v7:
> use macro to define "intcap" in pc.h
> (as to 3/4 and 4/4, I am not sure about whether to merge them or not, so
> keep them separate")
>
Yes, please smash 2 3 and 4 together.
There's no need to waste time reviewing code that gets
deleted in the next patch.
> v6:
> move the setting of intcap to board, and keep the init value as zero.
> (thanks for the discussion from Paolo and Michael)
> introduce an extra hpet property "compat" to tell PC version
>
> v5:
> use stand compat property to fix hpet intcap on pc-q35, while on pc-piix,
> hard code intcap as IRQ2
>
> v4:
> use stand compat property to fix hpet intcap
>
> v3:
> change hpet interrupt capablity on board's demand
>
>
>
> Liu Ping Fan (4):
> hpet: inverse polarity when pin above ISA_NUM_IRQS
> hpet: enable to entitle more irq pins for hpet
> PC: use qdev_xx to create hpet instead of sysbus_create_xx
> PC: differentiate hpet's interrupt capability on piix and q35
>
> hw/i386/pc.c | 23 ++++++++++++++++++++---
> hw/i386/pc_piix.c | 7 ++++++-
> hw/i386/pc_q35.c | 6 +++++-
> hw/timer/hpet.c | 24 ++++++++++++++++++++----
> include/hw/i386/pc.h | 13 ++++++++++++-
> 5 files changed, 63 insertions(+), 10 deletions(-)
>
> --
> 1.8.1.4
- [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet, Liu Ping Fan, 2013/10/16
- [Qemu-devel] [PATCH v7 1/4] hpet: inverse polarity when pin above ISA_NUM_IRQS, Liu Ping Fan, 2013/10/16
- [Qemu-devel] [PATCH v7 2/4] hpet: enable to entitle more irq pins for hpet, Liu Ping Fan, 2013/10/16
- [Qemu-devel] [PATCH v7 3/4] PC: use qdev_xx to create hpet instead of sysbus_create_xx, Liu Ping Fan, 2013/10/16
- [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35, Liu Ping Fan, 2013/10/16
- Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35, Paolo Bonzini, 2013/10/17
- Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35, Paolo Bonzini, 2013/10/17
- Re: [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet,
Michael S. Tsirkin <=