Re: [Qemu-devel] [PATCH 4/7] usb-hcd-xhci: Remove unused sstreamsm member from XHCIStreamContext

[Hans de Goede]

Hi,

On 09/24/2013 11:37 AM, Gerd Hoffmann wrote:
> On Mo, 2013-09-23 at 20:54 +0200, Hans de Goede wrote:
> > Signed-off-by: Hans de Goede <address@hidden>
>
> Patch doesn't apply.

Sorry, my bad, I had some other changes in my local tree
which I was not yet ready to send and this depended on them.

I'm ready to send the whole bunch of patches in one go now,
which I'll do directly after this mail.

> That are bits for the (not fully implemented yet) secondary stream
> arrays btw.

I know, but ...

> We might complete the implementation instead of kicking
> them out.

Looking at the spec, I don't think any guest drivers will implement
secondary streams, the lsa can handle any reasonable amount of streams
just fine. The whole secondary stream thing is only interesting
if you want to do insane amount streams, or have stream id ranges
with holes in them.

> I have no idea whenever there is a reasonable way to test
> that though ...

I agree, and I'm not sure there ever will be. So I vote for not worrying
about secondary streams until we actually encounter a guest which uses
them (at which point we should have a way to test through that guest).

So my vote goes to just removing this cruft for now.

Regards,

Hans