[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V14 02/11] NUMA: check if the total numa memory size
From: |
Wanlong Gao |
Subject: |
[Qemu-devel] [PATCH V14 02/11] NUMA: check if the total numa memory size is equal to ram_size |
Date: |
Mon, 7 Oct 2013 16:31:27 +0800 |
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table
and recognize all memory to one node. It's buggy, we should
check it to ensure that we write the right data to ACPI table.
Signed-off-by: Wanlong Gao <address@hidden>
---
numa.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/numa.c b/numa.c
index ce7736a..beda80e 100644
--- a/numa.c
+++ b/numa.c
@@ -150,6 +150,16 @@ void set_numa_nodes(void)
node_mem[i] = ram_size - usedmem;
}
+ uint64_t numa_total = 0;
+ for (i = 0; i < nb_numa_nodes; i++) {
+ numa_total += node_mem[i];
+ }
+ if (numa_total != ram_size) {
+ fprintf(stderr, "qemu: numa nodes total memory size "
+ "should equal to ram_size\n");
+ exit(1);
+ }
+
for (i = 0; i < nb_numa_nodes; i++) {
if (!bitmap_empty(node_cpumask[i], MAX_CPUMASK_BITS)) {
break;
--
1.8.4.474.g128a96c
- [Qemu-devel] [PATCH V14 00/11] Add support for binding guest numa nodes to host numa nodes, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 07/11] NUMA: expand MAX_NODES from 64 to 128, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 09/11] NUMA: set guest numa nodes memory policy, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 05/11] NUMA: introduce NumaMemOptions, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 08/11] NUMA: parse guest numa nodes memory policy, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 06/11] NUMA: add "-numa mem," options, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 02/11] NUMA: check if the total numa memory size is equal to ram_size,
Wanlong Gao <=
- [Qemu-devel] [PATCH V14 03/11] NUMA: Add numa_info structure to contain numa nodes info, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 01/11] NUMA: move numa related code to new file numa.c, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 04/11] NUMA: convert -numa option to use OptsVisitor, Wanlong Gao, 2013/10/07
- [Qemu-devel] [PATCH V14 10/11] NUMA: add qmp command query-numa, Wanlong Gao, 2013/10/07
- Re: [Qemu-devel] [PATCH V14 00/11] Add support for binding guest numa nodes to host numa nodes, Wanlong Gao, 2013/10/15
- Re: [Qemu-devel] [PATCH V14 00/11] Add support for binding guest numa nodes to host numa nodes, Wanlong Gao, 2013/10/20