Re: [Qemu-devel] [PATCH RFC v2 7/9] hw: set interrupts using pci irq wrappers

[Marcel Apfelbaum]

On Mon, 2013-10-07 at 09:02 +0200, Gerd Hoffmann wrote:
> On Mi, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote:
> > --- a/hw/usb/hcd-uhci.c
> > +++ b/hw/usb/hcd-uhci.c
> > @@ -381,7 +381,7 @@ static void uhci_update_irq(UHCIState *s)
> >      } else {
> >          level = 0;
> >      }
> > -    qemu_set_irq(s->dev.irq[s->irq_pin], level);
> > +    pci_set_irq(&s->dev, level);
> >  }
> >  
> >  static void uhci_reset(void *opaque)
> 
> That renders s->irq_pin unused.  You can drop the struct member and the
> initialization code for it.
Got it, thanks!
Marcel

> 
> cheers,
>   Gerd
> 
>