Re: [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L in convert

[Eric Blake]

On 09/25/2013 06:16 PM, Wenchao Xia wrote:
> Also renamed snapshot_name to snapshot_id_or_name to tip better.

s/to tip better/as a better hint of what it does/

> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  qemu-img-cmds.hx |    2 +-
>  qemu-img.c       |    2 ++
>  qemu-img.texi    |    7 +++++--
>  3 files changed, 8 insertions(+), 3 deletions(-)

Squash this into 5/7.

> +           "  'snapshot_param' is param used for internal snapshot, format 
> is\n"
> +           "    'snapshot.id=[ID],snapshot.name=[NAME]'\n"

Again, can you reuse the existing -s, instead of having to add -L, by
making the command line parser smarter about whether it is seeing a
single name vs. a string starting with 'snapshot.'?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature