[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 5/7] qcow2: use debug events for snapshot
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V3 5/7] qcow2: use debug events for snapshot |
Date: |
Mon, 30 Sep 2013 15:41:35 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 09/08/2013 08:58 PM, Wenchao Xia wrote:
> For those error paths which can't be triggered by other debug event,
> use snapshot debug events.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/qcow2-snapshot.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
I would have squashed 4 and 5 into a single patch (declaring the enums
doesn't add any functionality without the event actually using the enum
values, and neither patch is so large in isolation where combining them
would ips the balance towards too large).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V3 2/7] qcow2: free allocated cluster on fail in qcow2_write_snapshots(), (continued)
- [Qemu-devel] [PATCH V3 6/7] qcow2: print message for error path in snapshot creation, Wenchao Xia, 2013/09/08
- [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation, Wenchao Xia, 2013/09/08
- [Qemu-devel] [PATCH V3 4/7] blkdebug: add debug events for snapshot, Wenchao Xia, 2013/09/08
- [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for qcow2 snapshot, Wenchao Xia, 2013/09/08
- [Qemu-devel] [PATCH V3 5/7] qcow2: use debug events for snapshot, Wenchao Xia, 2013/09/08
- Re: [Qemu-devel] [PATCH V3 5/7] qcow2: use debug events for snapshot,
Eric Blake <=
- Re: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation, Wenchao Xia, 2013/09/23