Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2

[Paolo Bonzini]

sh4 is ~orphan so nobody should complain if qemu-trivial picks this up
as well.

Paolo

Il 14/09/2013 06:04, Guenter Roeck ha scritto:
> On 09/08/2013 12:39 AM, Guenter Roeck wrote:
>> With Linux kernel version 3.3 or later, qemu fails with the following
>> message:
>>
>> sh_serial: unsupported read from 0x18
>>    Aborted
>>
>> Reported-and-analyzed-by: Rob Landley <address@hidden>
>> Signed-off-by: Guenter Roeck <address@hidden>
> 
> ping ...
> 
>> ---
>> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
>> for Rob's analysis of the problem. Unfortunately, the patch never made it
>> into qemu.
>>
>>   hw/char/sh_serial.c |    2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
>> index 6223a55..9328dd1 100644
>> --- a/hw/char/sh_serial.c
>> +++ b/hw/char/sh_serial.c
>> @@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque,
>> hwaddr offs,
>>                       s->flags &= ~SH_SERIAL_FLAG_RDF;
>>               }
>>               break;
>> -#if 0
>>           case 0x18:
>>               ret = s->fcr;
>>               break;
>> -#endif
>>           case 0x1c:
>>               ret = s->rx_cnt;
>>               break;
>>
>