[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] ioh3420: Add a map_irq function
From: |
Alexander Duyck |
Subject: |
Re: [Qemu-devel] ioh3420: Add a map_irq function |
Date: |
Fri, 27 Sep 2013 15:10:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 02/28/2013 10:49 AM, Alex Williamson wrote:
> Every bridge needs to know how to map IRQs from it's secondary bus to
> the primary bus. We seem to be direct mapped on ioh3420. This avoids
> segfaults when trying to put assigned devices behind root ports.
>
> Signed-off-by: Alex Williamson <address@hidden>
>
> ---
> hw/ioh3420.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/ioh3420.c b/hw/ioh3420.c
> index 95bceb5..6ac4fe7 100644
> --- a/hw/ioh3420.c
> +++ b/hw/ioh3420.c
> @@ -90,6 +90,11 @@ static void ioh3420_reset(DeviceState *qdev)
> pci_bridge_disable_base_limit(d);
> }
>
> +static int ioh3420_map_irq(PCIDevice *pci_dev, int irq_num)
> +{
> + return irq_num;
> +}
> +
> static int ioh3420_initfn(PCIDevice *d)
> {
> PCIBridge* br = DO_UPCAST(PCIBridge, dev, d);
> @@ -97,6 +102,8 @@ static int ioh3420_initfn(PCIDevice *d)
> PCIESlot *s = DO_UPCAST(PCIESlot, port, p);
> int rc;
>
> + pci_bridge_map_irq(br, NULL, ioh3420_map_irq);
> +
> rc = pci_bridge_initfn(d);
> if (rc < 0) {
> return rc;
>
What became of this patch? I believe I am seeing the issue described
when I assign a MSI-X capable virtual device to the secondary bus of an
ioh3420, and applying this patch seems to resolve the issue. Was there
an alternate patch proposed and if so where can I find it?
Thanks,
Alex
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] ioh3420: Add a map_irq function,
Alexander Duyck <=