[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3] block: introduce BlockDriver.bdrv_needs_file

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V3] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.
Date: Tue, 24 Sep 2013 07:03:15 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/24/2013 06:27 AM, Benoît Canet wrote:
> Some drivers will have driver specifics options but no filename.
> This new bool allow the block layer to treat them correctly.
> The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and
> not having .bdrv_open.
> The first exception to this rule will be the quorum driver.
> Signed-off-by: Benoit Canet <address@hidden>
> ---

> +++ b/include/block/block_int.h
> @@ -73,6 +73,11 @@ struct BlockDriver {
>      /* Any driver implementing this callback is expected to be able to handle
>       * NULL file names in its .bdrv_open() implementation */
>      void (*bdrv_parse_filename)(const char *filename, QDict *options, Error 
> **errp);
> +    /* Drivers not implementing bdrv_parse_filename nor bdrv_open should have
> +     * this field set to true excepted the ones only defined by their childs 
> bs.
> +     * An example of the last type will be the quorum block driver.


Drivers not implementing ... set to true, except ones that are defined
only by their child's bs.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]