[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extent

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents
Date: Mon, 23 Sep 2013 17:40:42 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, 09/23 17:18, Fam Zheng wrote:
> We use the extent size as cluster size for flat extents (where no L1/L2
> table is allocated so it's safe) reuse sector calculating code with
> sparse extents.
> Don't pass in the cluster size for adding flat extent, just set it to
> sectors later, then the cluster size checking will not fail.
> The cluster_sectors is changed to int64_t to allow big flat extent.
> Without this, flat extent opening is broken:
>     # qemu-img create -f vmdk -o subformat=monolithicFlat /tmp/a.vmdk 100G
>     Formatting '/tmp/a.vmdk', fmt=vmdk size=107374182400 compat6=off 
> subformat='monolithicFlat' zeroed_grain=off
>     # qemu-img info /tmp/a.vmdk
>     image: /tmp/a.vmdk
>     file format: raw
>     virtual size: 0 (0 bytes)
>     disk size: 4.0K
> Signed-off-by: Fam Zheng <address@hidden>
> ---

When adding a test case, iotests case 059 seems broken now, it will perhaps
take some time to check and I'll post a fix together with test case for this


reply via email to

[Prev in Thread] Current Thread [Next in Thread]