Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

[Paolo Bonzini]

Il 20/09/2013 22:41, Christoffer Dall ha scritto:
>> > kvm_arm_gic_dist_readr
>> > kvm_arm_gic_dist_writer
>> > 
>> > Why not get_reg/set_reg (I was quite surprised to see readr instead of
>> > reader :) and it took me a while to understand the convention)?  Or if
>> > the name is too long, s/readr/get/ and s/writer/set/ would be enough to
>> > match the ioctls.
>> > 
> r for register, read register, write register...
> 
> I thought I'd seen this convention elsewhere, but I may be wrong.  If
> you feel really strongly about it, I can rename.

Yeah, there is readb/w/l and writeb/w/l, but I only found readreg when
grepping for readr.  So I think get/set would be better.

Paolo