[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu-exec: Fix compiler warning (-Werror=clobber
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] cpu-exec: Fix compiler warning (-Werror=clobbered) |
|
Date: |
Tue, 17 Sep 2013 22:24:26 +0100 |
On 17 September 2013 18:03, Stefan Weil <address@hidden> wrote:
> could you please review this patch which removes code added by you earlier?
> I have run tests with the old code and assertions to see whether the values
> were really smashed. They never were, and from the documentation of setjmp
> I'd not expect that they ever might be.
We had a discussion about this back in 2011. Any compiler which needs
these statements is definitely buggy -- the C standard mandates that
they're not needed. Unfortunately Jan never said what compiler he
was using; obviously the ones the rest of us were using at the time
didn't have the bug.
http://patchwork.ozlabs.org/patch/102980/ has the discussion.
-- PMM