[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status |
Date: |
Tue, 17 Sep 2013 19:21:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 17/09/2013 19:18, Stefan Weil ha scritto:
> Latest QEMU git is broken on Debian wheezy:
>
> block/iscsi.c: In function ‘iscsi_co_get_block_status’:
> block/iscsi.c:842:5: error: implicit declaration of function
> ‘iscsi_get_lba_status_task’ [-Werror=implicit-function-declaration]
> block/iscsi.c:842:5: error: nested extern declaration of
> ‘iscsi_get_lba_status_task’ [-Werror=nested-externs]
> block/iscsi.c:845:43: error: comparison between pointer and integer
> [-Werror]
> block/iscsi.c:877:18: error: dereferencing pointer to incomplete type
> block/iscsi.c:879:55: error: dereferencing pointer to incomplete type
> block/iscsi.c:884:34: error: dereferencing pointer to incomplete type
> block/iscsi.c:889:14: error: dereferencing pointer to incomplete type
> block/iscsi.c:889:32: error: ‘SCSI_PROVISIONING_TYPE_DEALLOCATED’
> undeclared (first use in this function)
> block/iscsi.c:889:32: note: each undeclared identifier is reported only
> once for each function it appears in
> block/iscsi.c:890:14: error: dereferencing pointer to incomplete type
> block/iscsi.c:890:32: error: ‘SCSI_PROVISIONING_TYPE_ANCHORED’
> undeclared (first use in this function)
> cc1: all warnings being treated as errors
>
> Debian includes libiscsi-dev 1.4.0 without a libiscsi.pk, so it uses a
> compile test
> which thinks that libiscsi is good enough.
>
> Did the latest changes raise the requirements for libscsi?
Looks like. Can you make a patch that drops the definition of
iscsi_co_get_block_status if SCSI_PROVISIONING_TYPE_DEALLOCATED is not
#defined?
Thanks,
Paolo
- [Qemu-devel] [PULL 00/11] SCSI patches for 2013-09-11, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 02/11] spapr-vscsi: add task management, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 04/11] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 05/11] hw/scsi/lsi53c895a: Use sextract32 for sign-extension, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 01/11] scsi: prefer UUID to VM name for the initiator name, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 06/11] hw/scsi/lsi53c895a: Use deposit32 rather than handcoded shift/mask, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 03/11] virtio-scsi: Make type virtio-scsi-common abstract, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 07/11] iscsi: add logical block provisioning information to iscsilun, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status, Paolo Bonzini, 2013/09/12
[Qemu-devel] [PULL 09/11] iscsi: split discard requests in multiple parts, Paolo Bonzini, 2013/09/12
[Qemu-devel] [PULL 11/11] spapr-vscsi: Report error on unsupported MAD requests, Paolo Bonzini, 2013/09/12
[Qemu-devel] [PULL 10/11] spapr-vscsi: Adding VSCSI capabilities, Paolo Bonzini, 2013/09/12