[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on er
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on error |
Date: |
Tue, 17 Sep 2013 15:48:50 +0200 |
if the call is invoked through bdrv_is_allocated the caller might
expect *pnum = 0 on error. however, a new implementation of
bdrv_get_block_status might only return a negative exit value on
error while keeping *pnum untouched.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
---
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.c
index 88b137c..805ee26 100644
--- a/block.c
+++ b/block.c
@@ -3188,6 +3188,7 @@ static int64_t coroutine_fn
bdrv_co_get_block_status(BlockDriverState *bs,
ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, pnum);
if (ret < 0) {
+ *pnum = 0;
return ret;
}
--
1.7.9.5
- Re: [Qemu-devel] [PATCHv2 09/20] iscsi: simplify iscsi_co_discard, (continued)
- [Qemu-devel] [PATCHv2 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 12/20] iscsi: add bdrv_co_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 07/20] block: honour alignment and limit in bdrv_co_do_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on error,
Peter Lieven <=
- [Qemu-devel] [PATCHv2 13/20] block: introduce bdrv_zeroize, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 15/20] block/get_block_status: avoid segfault if there is no backing_hd, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 20/20] block/raw: copy block limits and alignment information on raw_open, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/09/17