[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in tcg_out_op |
Date: |
Tue, 17 Sep 2013 10:05:51 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 16.09.2013 17:07, Richard Henderson wrote:
> On 09/16/2013 12:45 AM, Claudio Fontana wrote:
>>>> default:
>>>> - tcg_abort(); /* opcode not implemented */
>>>> + /* Opcode not implemented. */
>>>> + tcg_abort();
>>>> }
>>>> }
>> This change above seems unnecessary.
>
> Perhaps qemu doesn't have the same "comments are sentences" rule that gcc
> does,
> but I still aim to follow it.
>
It is wasteful of y space for no reason. This comment is not a sentence, when
you read the code as you would prose.
It is a comment _on_ tcg_abort() : tcg_abort(), because the opcode is not
implemented.
In other cases, the comment alone on a line is a good idea, but not in this one.
C.
- [Qemu-devel] [PATCH v4 00/33] tcg-aarch64 improvements, Richard Henderson, 2013/09/14
- [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/14
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Claudio Fontana, 2013/09/16
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/16
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Claudio Fontana, 2013/09/17
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/17
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Claudio Fontana, 2013/09/18
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/18
- Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op, Claudio Fontana, 2013/09/18
[Qemu-devel] [PATCH v4 05/33] tcg-aarch64: Change enum aarch64_arith_opc to AArch64Insn, Richard Henderson, 2013/09/14
[Qemu-devel] [PATCH v4 06/33] tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insn, Richard Henderson, 2013/09/14