[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abo
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort |
Date: |
Sun, 15 Sep 2013 18:32:13 +0100 |
On 15 September 2013 18:30, Michael S. Tsirkin <address@hidden> wrote:
> On Sun, Sep 15, 2013 at 07:16:41PM +0300, Marcel Apfelbaum wrote:
>> +static const MemoryRegionOps master_abort_mem_ops = {
>> + .read = master_abort_mem_read,
>> + .write = master_abort_mem_write,
>> + .endianness = DEVICE_NATIVE_ENDIAN,
>> +};
>> +
>
> Please make it little endian.
> DEVICE_NATIVE_ENDIAN is almost always a bug.
...when dealing with PCI devices. For a random device on the system bus
it's often correct.
-- PMM
- [Qemu-devel] [PATCH v4 0/3] pci: implement upstream master abort protocol, Marcel Apfelbaum, 2013/09/15
- [Qemu-devel] [PATCH v4 1/3] memory: allow MemoryRegion's priority field to accept negative values, Marcel Apfelbaum, 2013/09/15
- [Qemu-devel] [PATCH v4 2/3] docs/memory: Explicitly state that MemoryRegion priority is signed, Marcel Apfelbaum, 2013/09/15
- [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Marcel Apfelbaum, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Michael S. Tsirkin, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Marcel Apfelbaum, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Michael S. Tsirkin, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Peter Maydell, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Michael S. Tsirkin, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Peter Maydell, 2013/09/15
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Michael S. Tsirkin, 2013/09/16
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Peter Maydell, 2013/09/16
- Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort, Marcel Apfelbaum, 2013/09/15