[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/15] target-i386: Fix segment cache dump
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 12/15] target-i386: Fix segment cache dump |
Date: |
Sat, 14 Sep 2013 23:47:38 +0400 |
From: Tobias Markus <address@hidden>
When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default
operation size bit (D/B bit) is not set for Long Mode Data Segments since
there are only Data Segments in Long Mode and no explicit 16/32/64-bit
Descriptors.
This patch fixes this by checking the Long Mode Active bit of the hidden
flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data
Segments are logged as "DS")
Signed-off-by: Tobias Markus <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
target-i386/helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 7c58e27..eef3334 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -147,7 +147,9 @@ cpu_x86_dump_seg_cache(CPUX86State *env, FILE *f,
fprintf_function cpu_fprintf,
cpu_fprintf(f, " [%c%c", (sc->flags & DESC_C_MASK) ? 'C' : '-',
(sc->flags & DESC_R_MASK) ? 'R' : '-');
} else {
- cpu_fprintf(f, (sc->flags & DESC_B_MASK) ? "DS " : "DS16");
+ cpu_fprintf(f,
+ (sc->flags & DESC_B_MASK || env->hflags & HF_LMA_MASK)
+ ? "DS " : "DS16");
cpu_fprintf(f, " [%c%c", (sc->flags & DESC_E_MASK) ? 'E' : '-',
(sc->flags & DESC_W_MASK) ? 'W' : '-');
}
--
1.7.10.4
- [Qemu-devel] [PULL 03/15] docs: Fix IO port number for CPU present bitmap., (continued)
- [Qemu-devel] [PULL 03/15] docs: Fix IO port number for CPU present bitmap., Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 05/15] translate-all: Fix formatting of dump output, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 02/15] q35: Fix typo in constant DEFUALT -> DEFAULT., Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 10/15] vscclient: remove unnecessary use of uninitialized variable, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 13/15] Makefile: Remove some more files when cleaning, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 09/15] trace-events: Clean up with scripts/cleanup-trace-events.pl again, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 06/15] MAINTAINERS: Add missing entry to filelist for TCI target, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 14/15] tcg-sparc: Fix parenthesis warning, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 12/15] target-i386: Fix segment cache dump,
Michael Tokarev <=
- [Qemu-devel] [PULL 08/15] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions), Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 04/15] *-user: Fix typo in comment (ulocking -> unlocking), Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 15/15] configure: Enable extra compiler warnings, Michael Tokarev, 2013/09/14
- Re: [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14, Anthony Liguori, 2013/09/17