[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/12] block/get_block_status: avoid segfault if
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 10/12] block/get_block_status: avoid segfault if there is no backing_hd |
Date: |
Fri, 13 Sep 2013 12:26:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/13/2013 04:25 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block.c b/block.c
> index 4922fb9..cf9db62 100644
> --- a/block.c
> +++ b/block.c
> @@ -3156,7 +3156,7 @@ static int64_t coroutine_fn
> bdrv_co_get_block_status(BlockDriverState *bs,
> if (!(ret & BDRV_BLOCK_DATA)) {
> if (bdrv_has_zero_init(bs)) {
> ret |= BDRV_BLOCK_ZERO;
> - } else {
> + } else if (bs->backing_hd) {
> BlockDriverState *bs2 = bs->backing_hd;
> int64_t length2 = bdrv_getlength(bs2);
> if (length2 >= 0 && sector_num >= (length2 >> BDRV_SECTOR_BITS))
> {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 05/12] block: add logical block provisioning information to BlockDriverInfo, (continued)
[Qemu-devel] [PATCH 06/12] iscsi: add .bdrv_get_info, Peter Lieven, 2013/09/13
[Qemu-devel] [PATCH 11/12] block/get_block_status: avoid redundant callouts on raw devices, Peter Lieven, 2013/09/13
[Qemu-devel] [PATCH 09/12] block/get_block_status: set *pnum = 0 on error, Peter Lieven, 2013/09/13
[Qemu-devel] [PATCH 10/12] block/get_block_status: avoid segfault if there is no backing_hd, Peter Lieven, 2013/09/13
- Re: [Qemu-devel] [PATCH 10/12] block/get_block_status: avoid segfault if there is no backing_hd,
Eric Blake <=
[Qemu-devel] [PATCH 12/12] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/09/13