[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong asse

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Date: Thu, 12 Sep 2013 11:39:08 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/12/2013 11:17 AM, Stefan Weil wrote:
> @@ -1093,7 +1093,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t 
> *tb_ptr)
>              tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
>  #else
>              host_addr = (tcg_target_ulong)taddr;
> -            assert(taddr == host_addr);
>              tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
>  #endif

I noticed first that g2h would be better than fiddling GUEST_BASE
by hand.  But then I noticed failure to handle endianness and
failure to handle unaligned accesses too.

You should be using

  tmp8 = ldub(taddr);

et al.  See include/exec/cpu-all.h, beginning line 253.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]