[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] block: Assert validity of BdrvActionOps

From: Max Reitz
Subject: [Qemu-devel] [PATCH] block: Assert validity of BdrvActionOps
Date: Thu, 12 Sep 2013 14:57:27 +0200

In qmp_transaction, assert that the BdrvActionOps to be used is actually

This assertion failing is very improbable, however, it might happen, if
a new TransactionActionKind is introduced "out of order" and the
actions[] array is not updated.

Signed-off-by: Max Reitz <address@hidden>
 blockdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/blockdev.c b/blockdev.c
index 07dac05..14a0bb1 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1102,6 +1102,8 @@ void qmp_transaction(TransactionActionList *dev_list, 
Error **errp)
         assert(dev_info->kind < ARRAY_SIZE(actions));
         ops = &actions[dev_info->kind];
+        assert(ops->instance_size > 0);
         state = g_malloc0(ops->instance_size);
         state->ops = ops;
         state->action = dev_info;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]