[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-img: fix invalid JSON
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-img: fix invalid JSON |
|
Date: |
Wed, 11 Sep 2013 10:58:07 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/11/2013 10:47 AM, Paolo Bonzini wrote:
> Single quotes for JSON are a QMP-ism, use real JSON in
> qemu-img output.
>
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 3e5e388..626365d 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1842,7 +1842,7 @@ static void dump_map_entry(OutputFormat output_format,
> MapEntry *e,
> (e->flags & BDRV_BLOCK_ZERO) ? "true" : "false",
> (e->flags & BDRV_BLOCK_DATA) ? "true" : "false");
> if (e->flags & BDRV_BLOCK_OFFSET_VALID) {
> - printf(", 'offset': %"PRId64"", e->offset);
> + printf(", \"offset\": %"PRId64"", e->offset);
> }
> putchar('}');
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature