[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-module

From: Peter Maydell
Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules
Date: Wed, 11 Sep 2013 09:20:23 +0100

On 11 September 2013 09:01, Gerd Hoffmann <address@hidden> wrote:
> On Mi, 2013-09-11 at 09:41 +0200, Paolo Bonzini wrote:
>> It looks like TARGET_PAGE_SIZE is the only reason why qxl is built
>> per-target, and in qxl_ram_set_dirty it should be enough to do
>>     qxl_set_dirty(&qxl->vga.vram, offset, offset + 1);
>> Would it be fine to use a generic 4096 constant everywhere else?
> Yes.  Maybe s/TARGET_PAGE_SIZE/QXL_PAGE_SIZE/ to make clear that qxl
> operates on 4k pages.

Does this mean that the code was previously wrong for targets
which didn't have 4K pages, or would we just have been a bit
inefficient? I ask because ARM's TARGET_PAGE_SIZE is 1K...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]