Re: [Qemu-devel] [RFC qom-cpu v2 3/8] qmp: add 'cpu-del' command support

[chenfan]

On Tue, 2013-09-10 at 09:52 -0600, Eric Blake wrote:
> On 09/10/2013 03:43 AM, Chen Fan wrote:
> > Signed-off-by: Chen Fan <address@hidden>
> > ---
> >  hw/i386/pc.c         |  5 +++++
> >  hw/i386/pc_piix.c    |  1 +
> >  include/hw/boards.h  |  2 ++
> >  include/hw/i386/pc.h |  1 +
> >  qapi-schema.json     | 12 ++++++++++++
> >  qmp-commands.hx      | 23 +++++++++++++++++++++++
> >  qmp.c                |  9 +++++++++
> >  7 files changed, 53 insertions(+)
> > 
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 0c313fe..3de9c51 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -957,6 +957,11 @@ void pc_hot_add_cpu(const int64_t id, Error **errp)
> >      pc_new_cpu(current_cpu_model, apic_id, icc_bridge, errp);
> >  }
> >  
> > +void pc_hot_del_cpu(const int64_t id, Error **errp)
> > +{
> > +    /* TODO: hot remove vCPU. */
> 
> Even if you implement things later, it's better to at least set errp
> here rather than having a command that silently does nothing but
> succeeds.  Or squash the two patches together so that you are providing
> functionality at the time you expose the QMP.
I should temporarily set some errp here in this patch. Thanks for you
comment.

> 
> Otherwise, looks fine from the QMP perspective.
>