[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp: Documentation for BLOCK_IMAGE_CORRUPTED
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qmp: Documentation for BLOCK_IMAGE_CORRUPTED |
Date: |
Tue, 03 Sep 2013 07:39:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/02/2013 07:01 AM, Max Reitz wrote:
> Add an appropriate entry describing this event and its parameters into
> qmp-events.txt.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> Follow-up to:
> - Add metadata overlap checks (series, v5); particularly patch 2
> (qcow2: Metadata overlap checks)
> ---
> QMP/qmp-events.txt | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index 39b6016..6ff74d6 100644
> --- a/QMP/qmp-events.txt
> +++ b/QMP/qmp-events.txt
> @@ -478,3 +478,25 @@ Example:
>
> { "event": "GUEST_PANICKED",
> "data": { "action": "pause" } }
> +
> +BLOCK_IMAGE_CORRUPTED
> +---------------------
The content is fine, but the location is not. We are trying to keep
this file sorted by event name, so this belongs between BALLOON_CHANGE
and BLOCK_IO_ERROR.
As sorting is trivial, you can add this to your v2:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature