[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendmen
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendment |
Date: |
Tue, 3 Sep 2013 10:23:59 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.09.2013 um 12:04 hat Max Reitz geschrieben:
> Add tests for qemu-img amend on qcow2 image files.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/061 | 178 +++++++++++++++++++++++
> tests/qemu-iotests/061.out | 349
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 528 insertions(+)
> create mode 100755 tests/qemu-iotests/061
> create mode 100644 tests/qemu-iotests/061.out
It might be worth adding test cases for...
* Leaving an encrypted image encrypted, implicitly or explicitly
* Zero cluster expansion with an (active/inactive) L2 table with
refcount > 1
* State after a failed amend operation (or do we even promise anything?
I guess if you pass multiple options, some may be applied and some not)
What's there looks good (except for the one bug I mentioned)
Kevin
- [Qemu-devel] [PATCH v4 0/5] block/qcow2: Image file option amendment, Max Reitz, 2013/09/02
- [Qemu-devel] [PATCH v4 1/5] block: Image file option amendment, Max Reitz, 2013/09/02
- [Qemu-devel] [PATCH v4 2/5] qcow2-cluster: Expand zero clusters, Max Reitz, 2013/09/02
- [Qemu-devel] [PATCH v4 3/5] qcow2: Save refcount order in BDRVQcowState, Max Reitz, 2013/09/02
- [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendment, Max Reitz, 2013/09/02
- [Qemu-devel] [PATCH v4 4/5] qcow2: Implement bdrv_amend_options, Max Reitz, 2013/09/02