[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686

From: Richard W.M. Jones
Subject: Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686
Date: Mon, 2 Sep 2013 12:53:20 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

On Sat, Aug 31, 2013 at 06:36:17PM -0400, Cole Robinson wrote:
> Unlike other list types, enum wasn't adding any padding, which caused
> a mismatch between the generated struct size and GenericList struct
> size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21
> This crashed qemu if calling qmp query-tpm-types for example, which
> upsets libvirt capabilities probing. Reproducer on i686:
> (sleep 5; printf 
> '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') | 
> ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio
> https://bugs.launchpad.net/qemu/+bug/1219207
> Cc: address@hidden
> Signed-off-by: Cole Robinson <address@hidden>

Works for me, so you can add:

Tested-by: Richard W.M. Jones <address@hidden>


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]