[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/15] slirp: Port redirection option behave differen
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 01/15] slirp: Port redirection option behave differently on Linux and Windows |
Date: |
Mon, 2 Sep 2013 15:01:21 +0400 |
From: Taimoor Mirza <address@hidden>
port redirection code uses SO_REUSEADDR socket option before binding to
host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
Relaunching QEMU with same host and guest port redirection values on Linux
throws error but on Windows it does not throw any error.
Problem is discussed in
http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
Signed-off-by: Taimoor Mirza <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
slirp/socket.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/slirp/socket.c b/slirp/socket.c
index 8e8819c..25d60e7 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
@@ -627,7 +627,9 @@ tcp_listen(Slirp *slirp, uint32_t haddr, u_int hport,
uint32_t laddr,
addr.sin_port = hport;
if (((s = qemu_socket(AF_INET,SOCK_STREAM,0)) < 0) ||
+#ifndef _WIN32
(qemu_setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(int)) <
0) ||
+#endif
(bind(s,(struct sockaddr *)&addr, sizeof(addr)) < 0) ||
(listen(s,1) < 0)) {
int tmperrno = errno; /* Don't clobber the real reason we
failed */
--
1.7.10.4
- [Qemu-devel] [PULL 00/15] Trivial patches for 2013-09-02, Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 01/15] slirp: Port redirection option behave differently on Linux and Windows,
Michael Tokarev <=
- [Qemu-devel] [PULL 04/15] configure: disable clang -Wstring-plus-int warning, Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 02/15] misc: Fix some typos in names and comments, Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 03/15] rdma: silly ipv6 bugfix, Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 08/15] configure: Remove unneeded redirections of stderr (pkg-config --cflags, --libs), Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 12/15] tci: Remove function tcg_out64 (fix broken build), Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 11/15] target-arm: Report unimplemented opcodes (LOG_UNIMP), Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 05/15] slirp/arp_table.c: Avoid shifting into sign bit of signed integers, Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 13/15] qmp: fix integer usage in examples, Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 07/15] configure: Don't write .pyc files by default (python -B), Michael Tokarev, 2013/09/02
- [Qemu-devel] [PULL 10/15] pflash_cfi02.c: fix debug macro, Michael Tokarev, 2013/09/02