[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V7 0/8] add internal snapshot support at block d

From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH V7 0/8] add internal snapshot support at block device level
Date: Mon, 02 Sep 2013 09:44:31 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8

于 2013-8-16 23:36, Stefan Hajnoczi 写道:
On Wed, Aug 07, 2013 at 11:00:11AM +0800, Wenchao Xia wrote:
   Address Stefan's comments:
   2/8: macro STR_PRINT_CHAR was renamed as STR_OR_NULL, and moved into patch 5,
since implement function in this patch do not printf snapshot id any more, as
Kevin's suggestion.


   Address Kevin's comments:
   2/8: remove device, id, name info in the error message, use error message in
existing caller. A new function bdrv_snapshot_delete_by_id_or_name() is added
to make the usage clear while keep logic unchanged.
   3/8: remove device info in error message when name is empty. Use else if
after call of bdrv_snapshot_find_by_id_and_name().
   2/8: refined the comments in code for bdrv_snapshot_delete().
   3/8: in error reporting, change format from "reason is: '%s'" to
"reason is: %s".

Kevin: do you have time to review these changes?


Hi, Kevin
  Do you have comments for it?

Best Regards

Wenchao Xia

reply via email to

[Prev in Thread] Current Thread [Next in Thread]