|
From: | Max Reitz |
Subject: | Re: [Qemu-devel] [PATCH] qcow2-refcount: Snapshot update for zero clusters |
Date: | Thu, 29 Aug 2013 14:35:24 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Am 29.08.2013 14:30, schrieb Eric Blake:
On 08/29/2013 04:16 AM, Max Reitz wrote:Do not try to update the refcount for zero clusters in qcow2_update_snapshot_refcount.Why? What does this fix? (Hint - your commit message could use more details, and you should add a testsuite addition that exposes the case that you are fixing)
Okay, I'll put more detail into the message.The test case is actually kind of contained in my series "block/qcow2: Image file option amendment", but, of course, you're right, a dedicated test case won't hurt.
Max
[Prev in Thread] | Current Thread | [Next in Thread] |