[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel
|
From: |
James Hogan |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel |
|
Date: |
Wed, 28 Aug 2013 09:25:07 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 27/08/13 19:39, Richard Henderson wrote:
> On 08/27/2013 09:02 AM, James Hogan wrote:
>> The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu =
>> mips|mips64 when cross compiling, since endianness cannot be detected by
>> running a test program. This includes little endian MIPS though. It
>> didn't cause any build errors but does prevent QEMU from working
>> correctly. Instead, detect the endianness similar to how we do for ARM,
>> by checking for the __MIPSEB__ builtin processor definition.
>>
>> This is from a hunk in the "[PATCH 8/12] KVM/MIPS: Enable KVM/MIPS for
>> MIPS targets. Add MIPS GIC code to the build" patch by Sanjay Lal [1].
>
> Redundant with Mike Frysinger's more general patch,
>
> http://patchwork.ozlabs.org/patch/256001/
Even better. Thanks for pointing that out. I've added my tested-by.
Cheers
James