Re: [Qemu-devel] [PATCH 32/47] hw/misc/Kconfig: Add Kconfig file

[Paolo Bonzini]

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <address@hidden>
> ---
>  hw/misc/Kconfig |   67 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 67 insertions(+)
>  create mode 100644 hw/misc/Kconfig
> 
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> new file mode 100644
> index 0000000..5a6477f
> --- /dev/null
> +++ b/hw/misc/Kconfig
> @@ -0,0 +1,67 @@
> +config APPLESMC
> +    bool
> +    #select ISA
> +    
> +config MAX111X
> +    bool
> +    select SSI
> +
> +config TMP105
> +    bool
> +    #select I2C
> +
> +config ISA_DEBUG
> +    bool
> +    #select ISA
> +
> +config SGA
> +    bool
> +    #depends on PCI
> +
> +config ISA_TESTDEV
> +    bool
> +    #select ISA
> +
> +config PCI_TESTDEV
> +    bool
> +    depends on PCI
> +
> +config VMPORT
> +    bool
> +    #select ISA
> +
> +config PL310
> +    bool
> +
> +config PUV3
> +    bool
> +
> +config MACIO
> +    bool
> +    depends on PCI
> +    select MAC_NVRAM

Correct: this is a PCI device that embeds an MacIONVRAMState.

But it also embeds a MAC_DBDMA device, so "select MAC_DBDMA" too.

> +config CUDA
> +    bool
> +    select MACIO

Should be "select ADB" since this is a device that exposes an ADB bus.

> +config MAC_DBDMA
> +    bool   
> +    select MACIO
> +    select ADB
> +    #select ISA

Why these?  I think it doesn't need any of the three.

> +config A9SCU
> +    bool
> +
> +config ECCMEMCTL
> +    bool
> +    select ECC
> +
> +config OMAP
> +    bool
> +    select ECCMEMCTL
> +    select NAND
> +    
> +config PVPANIC
> +    bool
>