[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig |
Date: |
Mon, 26 Aug 2013 11:38:15 +0100 |
On 25 August 2013 23:58, Ákos Kovács <address@hidden> wrote:
> Signed-off-by: Ákos Kovács <address@hidden>
> ---
> hw/arm/Kconfig | 235
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 235 insertions(+)
> create mode 100644 hw/arm/Kconfig
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> new file mode 100644
> index 0000000..c72b949
> --- /dev/null
> +++ b/hw/arm/Kconfig
> @@ -0,0 +1,235 @@
> +config ARM
> + bool
> +# select ARM_NVIC
Why is this here but commented out?
> + default y
> +
> +menu "ARM"
> + config EXYNOS4
> + bool "Samsung Exynos4210 SoC"
> + select A9SCU # snoop controll unit
> + select USB_EHCI
> + select LAN9118
> + select PL310 # cache controller
> + select PCI
No PCI on this board (well, there is, but not modelled).
> + select ARM_GIC
> + select ARM_NVIC
This is wrong -- this CPU doesn't have an NVIC.
> + select ARM9MPCORE
This is misnamed: should be A9MPCORE.
> + select ARM_MPTIMER
Each Cortex-A9 platform shouldn't have to individually
select all of the components of the A9 individually
(GIC, mpcore container, mp timer, SCU) -- A9MPCORE
should just pull them all in.
> + default y
> +
> + config HIGHBANK
> + bool "Calxeda Highbank SoC"
> + select A9SCU # snoop controll unit
> + select AHCI
> + select PL011 # UART
> + select PL022 # Serial port
> + select PL031 # RTC
> + select PL061 # GPIO
> + select PL310 # cache controller
> + select XGMAC # ethernet
> + select ARM_TIMER # sp804
> + select ARM_NVIC
> + select ARM_MPTIMER
> + select ARM9MPCORE
> + select PCI
No PCI (yet).
> + default y
> +
> + config INTEGRATORCP
> + bool "ARM Integrator CP"
> + select SMC91C111
> + select ARM_TIMER
> + select PL011 # UART
> + select PL031 # RTC
> + select PL050 # keyboard/mouse
> + select PL110 # pl111 LCD controller
> + select PL181 # display
> + select PCI
No PCI.
> + default y
> +
> + config KZM
> + bool "Kzm"
> + select SERIAL
> + select IMX
> + select LAN9118
> + select PCI
No PCI.
> + default y
> +
> + config MUSICPAL
> + bool "Marvell MV88W8618 / Freecom MusicPal"
> + select PFLASH_CFI02
> + select PTIMER
> + select PCI
> + select BITBANG_I2C
> + select MARVELL_88W8618
> + select WM8750
> + select SERIAL
> + default y
> +
> + config OMAP
> + bool "Texas Instruments Open Multimedia Applications Platform"
Don't we want separate configs for OMAP1 and OMAP2?
> + select SERIAL
> + select PFLASH_CFI01
> + select PCI
No PCI.
> + default y
> +
> + config NSERIES
> + bool "Nokia N-Series tablets"
> + select TMP105 # tempature sensor
> + select BLIZZARD # LCD/TV controller
> + select ONENAND
> + select TSC210X # touchscreen/sensors/audio
> + select TSC2005 # touchscreen/sensors/keypad
> + select LM832X # GPIO keyboard chip
> + select TWL92230 # energy-management
> + depends on OMAP
Why 'depends on' rather than 'select' ?
> + default y
> +
> + config PALM
> + bool "PalmOne PDAs"
> + select TSC210X
> + depends on OMAP
> + default y
> +
> + config STELLARIS
> + bool
> + select PL011 # UART
> + select PL022 # Serial port
> + select PL061 # GPIO
> + select STELLARIS_INPUT
> + select STELLARIS_ENET # ethernet
> + select SSD0303 # OLED display
> + select SSD0323 # OLED display
> + select SSI_SD
> + default y # for armv7m_nvic_*
What is this comment trying to say?
> +
> + config REALVIEW
> + bool "ARM Realview baseboard"
> + # networking
> + select SMC91C111
> + select LAN9118
> + select RTL8139_PCI
This doesn't make any sense. Any board with PCI
should be compiled with all the PCI card models, so
there shouldn't be any need to manually select one here.
> +
> + select VERSATILE_PCI
> + select WM8750 # audio codec
> + select PL011 # UART
> + select PL041 # audio codec
> + select PL050 # keyboard/mouse
> + select PL061 # GPIO
> + select PL080 # DMA controller
> + select VERSATILE_I2C
> + select DS1338 # I2C RTC+NVRAM
> + select USB_OHCI
This is just a PCI card too, right?
> + select ARM_GIC
> + select ARM_MPTIMER
> + select ARM15MPCORE
> + select ARM11MPCORE
> + select ARM9MPCORE
> +
> + config VERSATILEPB
> + bool "ARM Versatile platform"
> + select PFLASH_CFI01
> + select PL031 # RTC
> + select PL050 # keyboard/mouse
> + select PL080 # DMA controller
> + select PL181 # display
> + select PL190 # Vector PIC
> + select ARM_TIMER # sp804
> + select USB_OHCI
> + select LSI_SCSI_PCI
> + select REALVIEW
Why does this board select the realview board?
> + default y
> +
> + config VXPRESS
"VEXPRESS".
> + bool "ARM Versatile Express"
> + select PFLASH_CFI01
> + select LAN9118
> + select PL011 # UART
> + select PL031 # RTC
> + select PL041 # audio codec
> + select PL110 # pl111 LCD controller
> + select PL181 # display
> + select PL310 # cache controller
> + select A9SCU # snoop controll unit
> + select ARM_TIMER # sp804
> + select ARM_MPTIMER
> + select ARM15MPCORE
> + select ARM9MPCORE
> + select REALVIEW
Why does this board select realview?
> + default y
> +
> + config ZYNQ
> + bool "Xilinx Zynq Baseboard"
> + select ARM9MPCORE
> + select CADENCE # UART
> + select PCI
Don't think this board has PCI either
> + select PFLASH_CFI02
> + select SDHCI
> + select USB_EHCI
> + select XILINX # UART
> + select XILINX_SPI
> + select XILINX_SPISS
> + default y
> +
> + config PXA2XX
> + bool "Intel XScale PXA255/270"
This is a CPU -- why does it get a config when other
CPUs don't?
> + select SERIAL
> + select PCI
No PCI here.
> + select USB_OHCI
> + select SSI
> + default y
> +
> + config GUMSTIX
> + bool "Gumstix platform"
> + select PFLASH_CFI01
> + select SMC91C111
> + depends on PXA2XX
Again, why depends?
> + default y
> +
> + config TOSA
> + bool "PXA255 Sharp Zaurus SL-6000 PDA platform"
> + select ZAURUS # scoop
> + select MICRODRIVE
> + depends on PXA2XX
> + default y
> +
> + config MAINSTONE
> + bool "PXA270-based Intel Mainstone"
> + depends on PXA2XX
> + select PFLASH_CFI01
> + select SMC91C111
> + default y
> +
> + config SPITZ
> + bool "PXA270-based Clamshell PDA platforms"
> + select ADS7846 # display
> + select MAX111X # A/D converter
> + select WM8750 # audio codec
> + select MAX7310 # GPIO expander
> + select ZAURUS # scoop
> + select NAND # memory
> + select ECC # Error-correcting for NAND
> + select MICRODRIVE
> + depends on PXA2XX
> + default y
> +
> + config Z2
> + bool "Zipit Z2"
> + select PFLASH_CFI01
> + select WM8750
> + select PL011 # UART
> + depends on PXA2XX
> + default y
> +
> + config STRONGARM
> + bool
> + select PXA2XX
Why does this select PXA2XX ?
> +
> + config COLLIE
> + bool "Sharp Zaurus SL-5500"
> + select PFLASH_CFI01
> + select ZAURUS # scoop
> + select STRONGARM
> + default y
> + help
> + SA-1110-based Sharp Zaurus SL-5500 platform.
> +endmenu
> --
> 1.7.10.4
thanks
-- PMM
- [Qemu-devel] [PATCH 10/47] hw/microblaze/Makefile.objs: Create configs for petalogix boards, (continued)
- [Qemu-devel] [PATCH 10/47] hw/microblaze/Makefile.objs: Create configs for petalogix boards, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 11/47] hw/mips/Makefile.objs: Create CONFIG_* for mips boards, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 12/47] hw/ppc/Makefile.objs: Build all boards conditinally, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 13/47] hw/sh4/Makefile.objs: Build sh4 boards conditionally, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 14/47] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 15/47] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 16/47] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_lx60 conditionally, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 17/47] hw/9pfs/Kconfig: Add 9pfs Kconfig, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 19/47] hw/audio/Kconfig: Add audio Kconfig, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 20/47] hw/block/Kconfig: Add Kconfig file, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file, Ákos Kovács, 2013/08/25
- [Qemu-devel] [PATCH 22/47] hw/core/Kconfig: Add Kconfig file, Ákos Kovács, 2013/08/25