[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target v
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCHv3] add qemu-img convert -C option (skip target volume creation) |
Date: |
Mon, 12 Aug 2013 13:11:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 12.08.2013 11:42, schrieb Alex Bligh:
> Add a -C option to skip volume creation on qemu-img convert.
> This is useful for targets such as rbd / ceph, where the
> target volume may already exist; we cannot always rely on
> qemu-img convert to create the image, as dependent on the
> output format, there may be parameters which are not possible
> to specify through the qemu-img convert command line.
>
> Code:
>
> Author: Alexandre Derumier <address@hidden>
> Signed-off-by: Alexandre Derumier <address@hidden>
> Signed-off-by: Alex Bligh <address@hidden>
>
> Documentaton:
>
> Author: Alex Bligh <address@hidden>
> Signed-off-by: Alex Bligh <address@hidden>
> ---
This is a rather odd notation...
The way git-commit works, any committer's Signed-off-by will be placed
directly under the documentation chunk, but it's supposed to cover the
whole commit/patch, not just some aspect of it.
Since as you write, the code is his, the patch should have his From, his
Signed-off-by and finally your Signed-off-by. You can detail your
changes in [AB: ...] or similar between the Signed-off-bys. (To change
the authorship, use git commit --amend --author="Name <email>".)
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg