qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add aio_timer_new w


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add aio_timer_new wrapper
Date: Fri, 09 Aug 2013 16:58:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

Il 09/08/2013 16:57, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 15:51, Paolo Bonzini wrote:
> 
>>> One nit:
>>>
>>> Currently struct QEMUTimer lives nicely within qemu_timer.c, hidden
>>> from the .h, which only contains:
>>>  typedef struct QEMUTimer QEMUTimer;
>>>
>>> If what you are after is for people to put a QEMUTimer into their
>>> struct, rather than a QEMUTimer * (and hopefully to remember to
>>> put qemu_timer_init in!) then I need to move the whole of the
>>> declaration of the struct to the .h file which is a bit yucky.
>>
>> Yeah, that's fine.  We're not relying too much on opaque types anyway.
> 
> Out of interest, there was some talk about modular block drivers
> (i.e. loading them at run time). If we do that, we'll need a stable
> API, and this would be a move in the wrong direction.

That's not a problem, there is absolutely no interest in out-of-tree
drivers and in having a stable ABI.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]