Re: [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling*

[Benoît Canet]

> It fail with the following error message at exit and I don't know why yet.
> qemu-system-x86_64: block.c:1489: bdrv_drain_all: Assertion
> `((&bs->tracked_requests)->lh_first == ((void *)0))' failed.

I solved this issue: bdrv_drain_all was bogus.

Best regards

Benoît

> 
>  block.c                   |  351 ++++++++++----------------------
>  block/qapi.c              |   50 +++--
>  blockdev.c                |  207 ++++++++++++++-----
>  hmp.c                     |   36 +++-
>  include/block/block.h     |    1 -
>  include/block/block_int.h |   32 +--
>  include/qemu/throttle.h   |  105 ++++++++++
>  qapi-schema.json          |   40 +++-
>  qemu-options.hx           |    4 +-
>  qmp-commands.hx           |   34 +++-
>  tests/Makefile            |    2 +
>  tests/test-throttle.c     |  494 
> +++++++++++++++++++++++++++++++++++++++++++++
>  util/Makefile.objs        |    1 +
>  util/throttle.c           |  391 +++++++++++++++++++++++++++++++++++
>  14 files changed, 1405 insertions(+), 343 deletions(-)
>  create mode 100644 include/qemu/throttle.h
>  create mode 100644 tests/test-throttle.c
>  create mode 100644 util/throttle.c
> 
> -- 
> 1.7.10.4
>