qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttlin


From: Benoît Canet
Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.
Date: Thu, 8 Aug 2013 15:37:38 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

> Kevin's series renamed these to have a dash in the name, and also moved
> all the throttling parameters into a sub-struct.  Does it make more
> sense to have just '*throttling' with that sub-struct containing 12
> parameters, 6 for limits and 6 for thresholds, or would it be better to
> have '*throttling' with 6 members for limits, as well as
> '*throttling-threshold' with the other 6 members?  Naming-wise,
> throttling.bps-total and throttling-threshold.bps-total convey as much
> information as throttling.bps-total and throttling.bps-total-threshold.

Eric & Kevin:

Should compatible old style values be added for the new throttling options in
order to avoid a mixed style mess in qemu-options.hx ?

Best regards

Benoît





reply via email to

[Prev in Thread] Current Thread [Next in Thread]