[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/5] Convert block layer callers' annotations

From: Charlie Shepherd
Subject: Re: [Qemu-devel] [PATCH 5/5] Convert block layer callers' annotations
Date: Thu, 08 Aug 2013 02:19:07 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7

On 05/08/2013 21:15, Gabriel Kerneis wrote:
On Mon, Aug 05, 2013 at 08:44:07PM +0200, Charlie Shepherd wrote:
This patch updates the callers of block layer functions converted to explicit
coroutine_fn annotation in the previous patch.
It looks like this patch is made of three parts:
- updating the annotations, following the rule "caller of coroutine_fn must be
- introducing a run_handler function in qemu-img.c,
- replacing bdrv_* by bdrv_*_sync in qemu-io-cmds.c.

The first one is purely mechanical and boring. The second one is moderately
inventive (note that I did not review the code in detail). The third one is
simple but definitely deserves some explanation. Again, I think this could be
split in three different patches, with an expanded commit message.

Ok thanks this seems like a logical way to split them up.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]