Re: [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes

[Stefan Hajnoczi]

On Tue, Aug 06, 2013 at 09:40:33AM +0800, Fam Zheng wrote:
> Fixes for VMDK sparse file opening. Header fields are checked before used for
> memory allocation.
> 
> v3:
>     00: Rebase to master.
>     04: Drop unused line in test script.
>     05: change vmdk_add_extent signature (uint64_t cluster_sectors).
>     06: Fix num_gtes_per_gte.
>     08: Use qemu_blockalign for whole_grain.
>         Don't allocate memory for !bs->backing_hd case.
> 
> Fam Zheng (9):
>   vmdk: Make VMDK3Header QEMU_PACKED
>   vmdk: Make VmdkGrainMarker QEMU_PACKED
>   vmdk: use unsigned values for on disk header fields
>   qemu-iotests: add empty test case for vmdk
>   vmdk: check granularity field in opening
>   vmdk: check l2 table size when opening
>   vmdk: check l1 size before opening image
>   vmdk: use heap allocation for whole_grain
>   vmdk: rename num_gtes_per_gte to num_gtes_per_gt
> 
> Stefan Hajnoczi (1):
>   qemu-iotests: add poke_file utility function
> 
>  block/vmdk.c                 | 104 
> ++++++++++++++++++++++++++++++-------------
>  tests/qemu-iotests/059       |  72 ++++++++++++++++++++++++++++++
>  tests/qemu-iotests/059.out   |  20 +++++++++
>  tests/qemu-iotests/common.rc |   6 +++
>  tests/qemu-iotests/group     |   1 +
>  5 files changed, 172 insertions(+), 31 deletions(-)
>  create mode 100755 tests/qemu-iotests/059
>  create mode 100644 tests/qemu-iotests/059.out

I'm happy now modulo Jeff's comments.