[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/5] Convert block layer callers' annotations

From: Gabriel Kerneis
Subject: Re: [Qemu-devel] [PATCH 5/5] Convert block layer callers' annotations
Date: Mon, 5 Aug 2013 21:15:16 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Aug 05, 2013 at 08:44:07PM +0200, Charlie Shepherd wrote:
> This patch updates the callers of block layer functions converted to explicit
> coroutine_fn annotation in the previous patch.

It looks like this patch is made of three parts:
- updating the annotations, following the rule "caller of coroutine_fn must be
- introducing a run_handler function in qemu-img.c,
- replacing bdrv_* by bdrv_*_sync in qemu-io-cmds.c.

The first one is purely mechanical and boring. The second one is moderately
inventive (note that I did not review the code in detail). The third one is
simple but definitely deserves some explanation. Again, I think this could be
split in three different patches, with an expanded commit message.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]