[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] Convert block functions to coroutine versio

From: Gabriel Kerneis
Subject: Re: [Qemu-devel] [PATCH 4/5] Convert block functions to coroutine versions
Date: Mon, 5 Aug 2013 21:01:20 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Aug 05, 2013 at 08:44:06PM +0200, Charlie Shepherd wrote:
> This patch follows on from the previous one and converts some block layer 
> functions to be
> explicitly annotated with coroutine_fn instead of yielding depending upon 
> calling context.

And just like the previous one, it also removes one annotation, which you
might want to mention in the commit message:

> -int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
> +int coroutine_fn bdrv_flush(BlockDriverState *bs)

By the way:

> diff --git a/block.c b/block.c
> index aaa122c..e7011f9 100644
> --- a/block.c
> +++ b/block.c
> @@ -364,7 +364,7 @@ BlockDriver *bdrv_find_whitelisted_format(const char 
> *format_name,
>  typedef struct CreateCo {
>      BlockDriver *drv;
> -    char *filename;
> +    const char *filename;
>      QEMUOptionParameter *options;
>      int ret;
>  } CreateCo;

This looks like an unrelated change which might deserve its own patch.  I'm not
sure what the QEMU policiy is about that kind of minor fix, but maybe send it to


reply via email to

[Prev in Thread] Current Thread [Next in Thread]