[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling |
|
Date: |
Mon, 05 Aug 2013 14:09:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-08-05 14:06, Andreas Färber wrote:
> Am 02.08.2013 19:22, schrieb Andreas Färber:
>> Error **errp argument is not for emitting warnings, it means an error
>> has occurred and the caller should not make any assumptions about the
>> state of other return values (unless otherwise documented).
>>
>> Therefore cpu_x86_create() must unref the new X86CPU itself, and
>> pc_new_cpu() must check for an Error rather than NULL return value.
>>
>> While at it, clean up a superfluous NULL check.
>>
>> Reported-by: Jan Kiszka <address@hidden>
>> Cc: address@hidden
>> Cc: Igor Mammedov <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
>
> Ping! Jan, does this address your concerns / use cases?
> -rc2 is on Wednesday.
Yes, thanks, this looks good.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux